feat(main): opt-in prompt logging#95
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a new ChangesPrompt capture config and telemetry
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for adding this. I think the feature is useful, but I want to clarify the behavior before we merge because prompts are already exported today in trace data. Currently prompt text is attached to OTel spans via OpenInference attributes:
So this PR does not add prompt capture for the first time. It adds an opt-in copy of the prompt into the That distinction matters for privacy/security expectations. With this change, Could you update the README/startup wording to make that explicit? Something like:
Also, repo convention is that config values are available both as I’m supportive of the feature as log enrichment, but I’d like the naming/docs to avoid implying this is the only control for prompt export. |
Description
Add the opt-in ability to log prompts.
Type of change
Checklist
bun run lintpasses with no errorsbun run check:jsdoc-coveragepasses with no errorsbun run typecheckpasses with no errorsbun testpasses with no errorsRelated issues
None related found
Additional context
N/A
Summary by CodeRabbit
New Features
user_prompttelemetry events.Bug Fixes
user_promptevents now consistently include prompt details only when prompt capture is enabled.Tests